Skip to content

fix: control active cleanup child jobs#446

Merged
chubes4 merged 3 commits into
mainfrom
fix/cleanup-run-child-control
May 24, 2026
Merged

fix: control active cleanup child jobs#446
chubes4 merged 3 commits into
mainfrom
fix/cleanup-run-child-control

Conversation

@chubes4

@chubes4 chubes4 commented May 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Route job-backed cleanup resume/cancel through active child jobs when a cleanup run has pending/processing/failed descendants.
  • Return controlled_job_ids and per-job control results so operators can see what was actually retried or cancelled.
  • Cover resume/cancel behavior in the worktree cleanup CLI smoke test.

Testing

  • php -l inc/Cli/Commands/WorkspaceCommand.php
  • php -l tests/smoke-worktree-cleanup-cli.php
  • php tests/smoke-worktree-cleanup-cli.php

Context

A local artifact cleanup run got stuck with parent job 2359 waiting on child job 2360. The existing workspace cleanup resume cleanup-run-2359 only controlled the parent job, leaving the active child in processing and the run summary blocked.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Diagnosing the stuck cleanup run, drafting the targeted CLI control fix, and adding smoke coverage. Chris remains responsible for review and merge.

@homeboy-ci

homeboy-ci Bot commented May 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

✅ lint — passed

ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since a3c3c5f

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/26363473259

Test

✅ test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since a3c3c5f

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/26363473259

Audit

✅ audit — passed

  • dead_code — 7 finding(s)
  • intra-method-duplication — 5 finding(s)
  • requested_detectors — 3 finding(s)
  • repeated_literal_shape — 1 finding(s)
  • structural — 1 finding(s)
  • Total: 17 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since a3c3c5f

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/26363473259
Tooling versions
  • Homeboy CLI: homeboy 0.197.9+ae73f21
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: d9f64c25
  • Action: unknown@unknown

@chubes4 chubes4 merged commit beeeaf9 into main May 24, 2026
5 checks passed
@chubes4 chubes4 deleted the fix/cleanup-run-child-control branch May 24, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chubes4